Only warn about missing features for mainstream modern browsers #490
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lionel-rowe - thanks for this PR. Good timing too, as I'm currently planning to jump back into RegExr maintenance / updates beginning early next week, after a long hiatus. I'll take a look then, and let you know if I have any specific feedback, but at a glance this looks good. |
|
@gskinner Even better timing — I just noticed https://caniuse.com/js-regexp-lookbehind has been updated, and it looks like iOS Safari 16.4 will ship with support for Will leave PR as-is for now though as iOS Safari 16.4 is still in beta. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #489:
Methodology: check caniuse for each feature, only including mainstream modern browsers (no IE, no Opera Mini, and ignoring the various Chinese browsers, which are all based on mainstream modern browser engines).
Sources:
neglookbehind,poslookbehind: https://caniuse.com/js-regexp-lookbehindsticky: https://caniuse.com/mdn-javascript_builtins_regexp_stickyunicode: https://caniuse.com/mdn-javascript_builtins_regexp_unicodedotall: https://caniuse.com/mdn-javascript_builtins_regexp_dotallunicodecat,unicodescript: https://caniuse.com/mdn-javascript_builtins_regexp_property_escapesnamedgroup: https://caniuse.com/mdn-javascript_builtins_regexp_named_capture_groupsResults: only
neglookbehindandposlookbehindare missing, thanks to iOS Safari. Presumably upcoming features like RegExpvflag will also lack comprehensive support for a while after they're officially added to the spec.